Hi Dominic, This is brilliant feedback. Can you open two separate JIRA tickets and we can work them through there? Also, see below for some comments,
On Sun, Oct 7, 2018 at 7:58 PM <dev-digest-h...@climate.apache.org> wrote: > > First, it seems necessary to conda install proj4 in addition to ocw > (perhaps that should be a dependency?) If it needs to be installed then yes it certainly should be a dependency. Please submit a pull request and we can try it out. Maybe this has to do with Basemap packaging for Windows... I'm not sure. > > Second, it seems axes_grid1/axes_grid.py has this curious condition: > > if ngrids is None: > ngrids = self._nrows * self._ncols > else: > if not 0 <= ngrids < self._nrows * self._ncols: > raise Exception > > This exception happens (see below); that comparison looks off-by-one > (ngrids <= self._nrows * self._ncols). > I would need to step through the code to see the variable values, also this code is not for OCW so we would need to pick up the conversation over at MPL repository. You may have a also seen recently that Kyo opened an issue on JIRA recently on upgrading matplotlib as well https://issues.apache.org/jira/browse/CLIMATE-961 > > I'd love to help out, is there a pointer to how to develop with some local > packages, eg a local fork of axes_grid1, instead of conda versions? The pointer would be to clone that code and install it locally. Similarly you could install OCW from Git as well. > > All for now, > > Again thank you. If you could open JIRA issue for the above we can get started on this. Lewis
