----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11098/#review20495 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/classes.py <https://reviews.apache.org/r/11098/#comment42227> in the future you can create a Model object from a single Model file. This is still a work in progress, but the old Object Constructor still works. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py <https://reviews.apache.org/r/11098/#comment42229> An example of a Question/Answer code block that has been pulled out into an external function. There it can be called and maintained more easily. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py <https://reviews.apache.org/r/11098/#comment42231> This single list comprehension replaces the 40 line block. Most of this Q&A logic has been pushed to the misc module. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py <https://reviews.apache.org/r/11098/#comment42232> Another candidate block of code that should be factored out into an external function http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py <https://reviews.apache.org/r/11098/#comment42234> This is a temporary code block to help this dev keep track of what information we need to collect, and when we can return back to the main processing calls. This will be removed when the JIRA issue is resolved. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py <https://reviews.apache.org/r/11098/#comment42235> OOPS. Metrics.py was not supposed to be part of this Review. I will remove it and post another version of this patch. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py <https://reviews.apache.org/r/11098/#comment42236> New hope for the Q/A stuff to get SubRegions from a user when a config file is not provided. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py <https://reviews.apache.org/r/11098/#comment42237> Another example of a Q/A code function to help with SubRegion support - Cameron Goodale On May 13, 2013, 6:29 p.m., Cameron Goodale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11098/ > ----------------------------------------------------------- > > (Updated May 13, 2013, 6:29 p.m.) > > > Review request for Apache Open Climate. > > > Description > ------- > > Since many changes are needed to fully implement this change I have collected > up my progress thus far at JPL and I am pushing the changes to the ASF > project so others can see the changes, provide feedback, ask questions and > possibly help out. > > > This addresses bug CLIMATE-6. > https://issues.apache.org/jira/browse/CLIMATE-6 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/classes.py > 1480311 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/do_rcmes_processing_sub.py > 1480311 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py > 1480311 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py > 1480311 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py > 1480311 > > Diff: https://reviews.apache.org/r/11098/diff/ > > > Testing > ------- > > Simple testing by running rcmet.py without the '-c' flag. The code will get > through the RCMED Parameter selection, then it stops. > > (leviathan)chocobo2010:bin cgoodale$ python rcmet.py > Interactive mode has been enabled > Regional Climate Model Evaluation System BETA > Querying RCMED for available parameters... > Please enter workDir: > > /tmp > Please enter cacheDir: > > /tmp > Please select one of the following Temporal Grid Options: > > [0] - annual > [1] - monthly > [2] - daily > >>>0 > Please select one of the following Spatial Grid Options: > > [0] - obs > [1] - model > [2] - user > >>>0 > Please enter model file (or specify multiple files using wildcard): > > /Users/cgoodale/Desktop/RCMET-VM-Shared/sample_model_data/CORDEX/AFRICA_KNMI-RACMO2.2b_CTL_ERAINT_MM_50km_1989-2008_tasmax.nc > Select the variable you want to use for analysis/metrics: > [0] - time_bnds > [1] - rlon > [2] - lon > [3] - height > [4] - lat > [5] - rotated_pole > [6] - time > [7] - tasmax > [8] - rlat > >>>7 > (69) - cloud_area_fraction :: Monthly > (67) - surface_upwelling_shortwave_flux_assuming_clear_sky :: Monthly > (64) - surface_upwelling_shortwave_flux :: Monthly > (65) - toa_outgoing_shortwave_flux_assuming_clear_sky :: Monthly > (70) - solar_zenith_angle :: Monthly > (32) - CRU3.0 Precipitation :: monthly > (75) - NCEP CPC Rain-gauge analysis :: Monthly > (15) - AIRS Level 3 Surface Air Temp Ascending :: daily > (76) - NARR 200 hPa Temperature :: monthly > (74) - GPCP Version 2.2 Combined Precipitation Data Set :: Monthly > (33) - CRU3.0 Daily-Mean Temperature :: monthly > (34) - CRU3.0 Daily-Maximum Temperature :: monthly > (36) - TRMM v.6 Monthly Precipitation :: monthly > (16) - AIRS Level 3 Surface Air Temp Descending :: daily > (66) - surface_downwelling_shortwave_flux_assuming_clear_sky :: Monthly > (42) - CRU3.1 Cloud Fraction :: monthly > (37) - CRU3.1 Precipitation :: monthly > (38) - CRU3.1 Daily-Mean Temperature :: monthly > (39) - CRU3.1 Daily-Maximum Temperature :: monthly > (41) - CRU3.1 Daily-Minimum Temperature :: monthly > (53) - CRE Net Flux :: Daily > (71) - average_solar_zenith_angle :: Monthly > (51) - CRE Shortwave Flux :: Daily > (52) - CRE Longwave Flux :: Daily > (54) - Incoming Solar Flux :: Daily > (62) - toa_outgoing_shortwave_flux :: Monthly > (63) - surface_downwelling_shortwave_flux :: Monthly > (30) - NCEP/CPC Daily Precipitation :: daily > Please select the available observation you would like to use from the list > above: > >>>39 > > > Thanks, > > Cameron Goodale > >
