----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11356/#review20958 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/bin/rcmet.py <https://reviews.apache.org/r/11356/#comment43258> During the rcmet_ui work I tried to re-use as much code as possible. I found this little bit down in the data_prep step, so I moved it up here where it makes more sense. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/classes.py <https://reviews.apache.org/r/11356/#comment43259> gridLonStep and gridLatStep are only used if someone specifies a custom spatitialGrid. This makes it possible to build a JobProperties object without using a custom grid. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/classes.py <https://reviews.apache.org/r/11356/#comment43261> Forcing this attribute to False to get the code working. Most likely this will be removed in the near future. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/do_rcmes_processing_sub.py <https://reviews.apache.org/r/11356/#comment43263> All of the effort placed into rcmet.py and rcmet_ui.py have made 'do_rcmes_processing_sub.py' obsolete. Formally deprecating this file, or just removing it is for another issue, but for now Devs should know it is no longer in use. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py <https://reviews.apache.org/r/11356/#comment43266> These are no longer used. Next version of the patch will omit them. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py <https://reviews.apache.org/r/11356/#comment43268> Tried to make the calls here more uniform, where they are return values instead of updating an input dict. http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/do_data_prep.py <https://reviews.apache.org/r/11356/#comment43270> Moved up into the rcmet.py file http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py <https://reviews.apache.org/r/11356/#comment43271> Added try blocks to make the user input more resilient against bad input. - Cameron Goodale On May 23, 2013, 9:53 p.m., Cameron Goodale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11356/ > ----------------------------------------------------------- > > (Updated May 23, 2013, 9:53 p.m.) > > > Review request for Apache Open Climate. > > > Description > ------- > > This patch contains the final changes to make it possible for a very simple > Question Answer interaction via the command line. It will merely collect > user input in place of using a config file. > > > This addresses bug CLIMATE-6. > https://issues.apache.org/jira/browse/CLIMATE-6 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/bin/rcmet.py > 1482342 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/classes.py > 1485855 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/do_rcmes_processing_sub.py > 1485855 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/cli/rcmet_ui.py > 1485855 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/do_data_prep.py > 1485855 > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/utils/misc.py > 1485855 > > Diff: https://reviews.apache.org/r/11356/diff/ > > > Testing > ------- > > (leviathan)chocobo2010:bin cgoodale$ python rcmet.py > Interactive mode has been enabled > Regional Climate Model Evaluation System BETA > Querying RCMED for available parameters... > Please enter workDir: > > /tmp > Please enter cacheDir: > > /tmp > Please select one of the following Temporal Grid Options: > [0] - annual > [1] - monthly > [2] - daily > >>>1 > Please select one of the following Spatial Grid Options: > [0] - obs > [1] - model > [2] - user > >>>1 > Please enter model file (or specify multiple files using wildcard): > > /tmp/*.nc > Select the variable you want to use for analysis/metrics: > [0] - time_bnds > [1] - rlon > [2] - lon > [3] - height > [4] - tasmax > [5] - rotated_pole > [6] - time > [7] - lat > [8] - rlat > >>>4 > (69) - cloud_area_fraction :: Monthly > (67) - surface_upwelling_shortwave_flux_assuming_clear_sky :: Monthly > (64) - surface_upwelling_shortwave_flux :: Monthly > (65) - toa_outgoing_shortwave_flux_assuming_clear_sky :: Monthly > (70) - solar_zenith_angle :: Monthly > (32) - CRU3.0 Precipitation :: monthly > (75) - NCEP CPC Rain-gauge analysis :: Monthly > (15) - AIRS Level 3 Surface Air Temp Ascending :: daily > (76) - NARR 200 hPa Temperature :: monthly > (74) - GPCP Version 2.2 Combined Precipitation Data Set :: Monthly > (33) - CRU3.0 Daily-Mean Temperature :: monthly > (34) - CRU3.0 Daily-Maximum Temperature :: monthly > (36) - TRMM v.6 Monthly Precipitation :: monthly > (16) - AIRS Level 3 Surface Air Temp Descending :: daily > (66) - surface_downwelling_shortwave_flux_assuming_clear_sky :: Monthly > (42) - CRU3.1 Cloud Fraction :: monthly > (37) - CRU3.1 Precipitation :: monthly > (38) - CRU3.1 Daily-Mean Temperature :: monthly > (39) - CRU3.1 Daily-Maximum Temperature :: monthly > (41) - CRU3.1 Daily-Minimum Temperature :: monthly > (53) - CRE Net Flux :: Daily > (71) - average_solar_zenith_angle :: Monthly > (51) - CRE Shortwave Flux :: Daily > (52) - CRE Longwave Flux :: Daily > (54) - Incoming Solar Flux :: Daily > (62) - toa_outgoing_shortwave_flux :: Monthly > (63) - surface_downwelling_shortwave_flux :: Monthly > (30) - NCEP/CPC Daily Precipitation :: daily > Please select the available observation you would like to use from the list > above: > >>>39 > ============================================================================================== > |Dataset - NAME |START DATE > |END DATE | > |CRU3.1 Daily-Maximum Temperature |1901-01-15 > |2009-12-15 | > ---------------------------------------------------------------------------------------------- > |AFRICA_MPI-REMO_CTL_ERAINT_MM_50km_1989-2008_tasmax.nc |1989-01-01 > |2008-12-01 | > ============================================================================================== > Standard Overlap in the selected datasets are 1989-01-01 through 2008-12-01 > Please Enter a Start Date [1989-01-01]: > Your time starts from [1989-01-01] > Please Enter an End Date [2008-12-01]: 1990-01-01 > start & end time = 1989-01-01 00:00:00 1990-01-01 00:00:00 > start & end eval period = 198901 199001 > regridOption in prep_data= model > read_lolaT_from_file: Lats, lons and times read in for the model domain > Your date range selection has been expanded to ensure we return the largest > number of available readings. > The new date Range is: 1989-01-01 00:00:00 through 1990-01-31 00:00:00 > Starting retrieval data (this may take several minutes) ...... > Regrid OBS dataset onto the model grid system: ngrdY, ngrdX, nstOBSs= 201 > 194 13 > For dataset: CRU3.1 Daily-Maximum Temperature > tmpOBS shape = (13, 201, 194) > OBS regridded: (1, 13, 201, 194) > ifile= /tmp/AFRICA_MPI-REMO_CTL_ERAINT_MM_50km_1989-2008_tasmax.nc > read_lolaT_from_file: Lats, lons and times read in for the model domain > success read_data_from_one_file: VarName= tasmax Shape(Full)= (240, 201, > 194) Unit= K > The shape of model data to be processed= (13, 201, 194) for the period > 1989-01-01 00:00:00 1990-01-01 00:00:00 > *** Begin calc_average_on_new_time_unit_KK *** > timeRegridOption= monthly > processing_required= False : input time steps= 13 : regridded output time > steps = 13 > data.ndim= 3 > *** End calc_average_on_new_time_unit_KK *** > Reading and regridding model data are completed > numMDLs, modelData.shape= 1 (1, 13, 201, 194) > data_prep is completed: both obs and mdl data are re-gridded to a common > analysis grid > Calculate area-mean timeseries for subregions? y/n: [n] > >>>n > > > OBS and MDL data have been prepared for the evaluation step > > Want to calculate metrics and plot them? [y/n] > > > Thanks, > > Cameron Goodale > >
