[ 
https://issues.apache.org/jira/browse/CLIMATE-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679679#comment-13679679
 ] 

Huikyo Lee commented on CLIMATE-88:
-----------------------------------

Yes, in my test, I did not restore the shape of data array. 
So there should be one more line.

dataset1.resize(dataShape)

I would just suggest the resize method as another alternative to your 
reshapeMonthlyData function.
In your routine, you also define another array, data so I am not sure if it is 
actually make big differences regarding memory allocation.

Kyo




                
> Performance improvements for metrics.py
> ---------------------------------------
>
>                 Key: CLIMATE-88
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-88
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>          Components: metrics
>    Affects Versions: 0.1-incubating
>            Reporter: Alex Goodman
>            Assignee: Chris A. Mattmann
>             Fix For: 0.1-incubating
>
>         Attachments: benchmark_metrics.py, 
> benchmark_metrics_with_resize_method.py
>
>
> The performance for many of the functions in metrics.py can be improved by 
> removing some unnecessary loops and utilizing shape manipulation. 
> I have attached some example code that benchmarks the differences between the 
> original and proposed methodology if you did not see it in the mailing list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to