> On June 13, 2013, 6:09 p.m., Michael Joyce wrote: > > /trunk/easy-rcmet/buildout.cfg, line 375 > > <https://reviews.apache.org/r/11855/diff/1/?file=304528#file304528line375> > > > > Not to beat a dead horse but if we're going to categorize "additional" > > dependencies all under a single category then we should adjust the other > > sections as well. Bottle would fall under the "dependencies" category as > > well. I prefer the individual sections for components so we don't have to > > parse through the build log to understand what in the world broke. If we > > have a bunch of dependencies under a single category that's going to end up > > being more work when something inevitably breaks. Explicit > Implicit in my > > opinion and we don't lose anything by having individual sections for each > > additional dependency. > > Chris Mattmann wrote: > So, what's the specific update?
"dependencies" is too generic of a name. Each section should handle a single component in my opinion (and be named appropriately). Makes debugging easier. Since this is installing requests we should call it "requests". If we have a "dependencies" section then 50% of the stuff installed by buildout falls under that category and that becomes messy. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11855/#review21866 ----------------------------------------------------------- On June 13, 2013, 12:26 a.m., Andrew Hart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11855/ > ----------------------------------------------------------- > > (Updated June 13, 2013, 12:26 a.m.) > > > Review request for Apache Open Climate. > > > Description > ------- > > This is a patch for CLIMATE-106 that includes the python "requests" module in > the list of things installed by easy_rcmet into the target environment. The > "requests" module is used by the web services (specifically > services/database_helpers.py). In the event that additional dependencies crop > up, I've updated the buildout.cfg file to include a "dependencies" part, > executed as the final processing step, to which the necessary installation > steps could be appended. > > > This addresses bug CLIMATE-106. > https://issues.apache.org/jira/browse/CLIMATE-106 > > > Diffs > ----- > > /trunk/easy-rcmet/buildout.cfg 1492445 > > Diff: https://reviews.apache.org/r/11855/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Hart > >
