----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12124/#review22497 -----------------------------------------------------------
Ship it! Kyo and Alex. I applied your patch to a local checkout of the trunk and it looks to me like you guys cleaned up metrics pretty well. Please apply these changes to the trunk. - Cameron Goodale On June 26, 2013, 11:15 p.m., Kyo Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12124/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 11:15 p.m.) > > > Review request for Apache Open Climate, Alex Goodman and Cameron Goodale. > > > Repository: climate > > > Description > ------- > > Regarding https://issues.apache.org/jira/browse/CLIMATE-169, > > Cameron found some critical bugs while calculating metrics and plotting them. > Alex and Kyo have fixed those bugs in metrics.py > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/metrics.py > 1497100 > > Diff: https://reviews.apache.org/r/12124/diff/ > > > Testing > ------- > > tested the updates using six NARCCAP model outputs with three different > observations. > > > Thanks, > > Kyo Lee > >
