> On July 15, 2013, 6 p.m., Kyo Lee wrote: > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/storage/files.py, > > lines 344-367 > > <https://reviews.apache.org/r/12452/diff/3/?file=319996#file319996line344> > > > > Could you also change this function, 'read_data_from_one_file', please? > > Those functions reading data from a list is not currently in use. > > Cameron Goodale wrote: > Kyo can you elaborate on this? What needs to be changed? > > Alex Goodman wrote: > Cam, > > I just opened another JIRA issue (CLIMATE-203) that elaborates on this > somewhat. This function actually needs to be reworked since reading the lats > / lons and the actual data from one netcdf file are being done by two > functions (this one and one other). However in order to fix CLIMATE-186, they > will need to be combined into one function as the data has to be rearranged > correctly based on lats / lons.
Alex, Thanks for the clarification. - Cameron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12452/#review23164 ----------------------------------------------------------- On July 16, 2013, 11:21 p.m., Alex Goodman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12452/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 11:21 p.m.) > > > Review request for Apache Open Climate, Cameron Goodale and Kyo Lee. > > > Repository: climate > > > Description > ------- > > This patch partially addresses CLIMATE-186 in that it can now handle data > with reversed or shifted lat lon grids. We have still not decided on how to > go about how to handle different calendars for daily data, so that patch will > come later. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/climate/trunk/rcmet/src/main/python/rcmes/toolkit/do_data_prep.py > 1493845 > > Diff: https://reviews.apache.org/r/12452/diff/ > > > Testing > ------- > > -NCEP Reanalysis Air Temperature Data to check if latitudes and associated > data are reversed properly > -Surface Air Temperature data from CMIP5 model output to test grid shift (eg > transform lon domain from [0, 360) to [-180, 180)) > > > Thanks, > > Alex Goodman > >
