> On Aug. 23, 2013, 12:04 a.m., Chris Mattmann wrote: > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset.py, > > line 55 > > <https://reviews.apache.org/r/13738/diff/1/?file=343842#file343842line55> > > > > any reason to expand this to more than 1 line? > > Cameron Goodale wrote: > Hey Chris, > > I just tested it on one line and it works, so I think it is just a matter > of personal taste (and vim auto-indents after lines that end with a colon).
+1, ship it! - Chris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13738/#review25440 ----------------------------------------------------------- On Aug. 22, 2013, 3:15 p.m., Cameron Goodale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13738/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 3:15 p.m.) > > > Review request for Apache Open Climate and Michael Joyce. > > > Bugs: CLIMATE-274 > https://issues.apache.org/jira/browse/CLIMATE-274 > > > Repository: climate > > > Description > ------- > > I created 5 different ValueError exception error messages for each different > check we perform when a Dataset object is initialized. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset.py > 1516193 > > Diff: https://reviews.apache.org/r/13738/diff/ > > > Testing > ------- > > I re-ran test_dataset.py and all 23 tests pass. > > > Thanks, > > Cameron Goodale > >
