-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13968/
-----------------------------------------------------------
Review request for Apache Open Climate, Cameron Goodale, Chris Mattmann, and
Paul Ramirez.
Bugs: CLIMATE-282
https://issues.apache.org/jira/browse/CLIMATE-282
Repository: climate
Description
-------
This patch represents progress towards merging in additional functionality
(multi-model/multi-obs evaluation parameters passed via OCW web UI, support for
generating additional plots -- taylor, portrait, time series -- from the OCW
web UI). It does not represent a complete refactorization. Rather it represents
enough progress that it makes sense to merge back with the trunk and proceed
alongside regular refactorization/improvement efforts ongoing there.
There's certainly still work to be done. Importantly, there are still
un-necessarily close ties between metrics calculation and plot generation in
some places that should be broken apart, and there are several places in which
custom calls should be replaced by their OCW api equivalents. Nevertheless,
this has been tested, and generates multiple plots for a multi-model ensemble
evaluation, which is a valuable improvement over the current UI's ability to
only generate contour diagrams.
Diffs
-----
/trunk/ocw/plotter.py 1520078
/trunk/rcmet/src/main/python/rcmes/services/run_rcmes_processing.py 1520078
/trunk/rcmet/src/main/python/rcmes/toolkit/do_data_prep.py 1520078
/trunk/rcmet/src/main/python/rcmes/toolkit/metrics_kyo.py PRE-CREATION
/trunk/rcmet/src/main/python/rcmes/utils/misc.py 1520078
/trunk/rcmet/src/main/ui/app/js/controllers/ParameterSelectCtrl.js 1520078
/trunk/rcmet/src/main/ui/app/js/controllers/RcmedSelectionCtrl.js 1520078
/trunk/rcmet/src/main/ui/app/partials/main.html 1520078
Diff: https://reviews.apache.org/r/13968/diff/
Testing
-------
This patch has been tested using the OCW API and successfully generates all
plots (contour, taylor, portrait, time series) for a multi-model/multi-obs
(ensemble) evaluation. It was also tested and found compatible with the recent
history/results features.
Thanks,
Andrew Hart
