On Thu, Apr 04, 2013 at 03:06:21PM +0000, Hugo Trippaers wrote:
> Hey Chip,
>
> This method used to be called from AgentManagerImpl, but it now uses the
> default constructor with Inject. So this method is no longer needed and I
> decided to remove it to avoid confusion. I dislike leaving constructor and
> methods around that are not used anymore as they tend to be unmaintained and
> become broken at some point.
>
> Cheers,
>
> Hugo
Thanks!
And I've cherry-picked over to 4.1 now:
commit 0c38d67816d34a6d9b069308c6814039a4aad21c
Author: Hugo Trippaers <htrippa...@schubergphilis.com>
Date: Thu Apr 4 14:23:42 2013 +0200
Fix for _pingTimeout being 0 in AgentMonitor
With commit d79f1f6fdc8307aa4038bfb2c7607904b89eedbe the AgentMonitor
was replaced with a pluggable service. However the ping timeout in the
original constructor was not passed on anymore, leading to a default
pingTimout of 0. This would fail all agents constantly.
Modified the startMonitor command to take a pingtimeout as an argument
and instruct AgentManagerImpl to pass it along.
