----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10336/#review18804 -----------------------------------------------------------
plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java <https://reviews.apache.org/r/10336/#comment39257> What's these trafficType and guestVlan for? Didn't see them in the scope. plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java <https://reviews.apache.org/r/10336/#comment39261> I am not sure if you need create application for egress rules. Ingress firewall don't need it. I suppose applications are for security policy rather than firewall filter? - Sheng Yang On April 8, 2013, 12:36 p.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10336/ > ----------------------------------------------------------- > > (Updated April 8, 2013, 12:36 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Sheng Yang, and Murali > Reddy. > > > Description > ------- > > Added egress firewall rules support for SRX device. > Supported networks: > 1. Advanced Isolated networks. > > > This addresses bug CLOUDSTACK-779. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/FirewallRuleTO.java 7f77936 > > plugins/network-elements/juniper-srx/src/com/cloud/network/element/JuniperSRXExternalFirewallElement.java > af0912a > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java > 8482168 > scripts/network/juniper/application-add.xml 6603850 > scripts/network/juniper/security-policy-add.xml 632a17d > server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java 1fc32d0 > > Diff: https://reviews.apache.org/r/10336/diff/ > > > Testing > ------- > > Unit Testing done. > > > Thanks, > > Jayapal Reddy > >
