----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review19245 -----------------------------------------------------------
tools/marvin/marvin/cloudstackConnection.py <https://reviews.apache.org/r/10294/#comment39861> How and when does marvin decide to use POST? Which commands will call the POST httpmethod? May be you can provide a more complete example when your test is ready. tools/marvin/marvin/cloudstackConnection.py <https://reviews.apache.org/r/10294/#comment39859> Are you sure you don't want to urlencode the POST data? tools/marvin/marvin/cloudstackConnection.py <https://reviews.apache.org/r/10294/#comment39860> Minor nitpick: urllib2.Request() can be used for both GET and POST and you can set the data argument only when you intend to use POST. That will reduce some code duplication here. - Prasanna Santhanam On April 16, 2013, 2:53 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10294/ > ----------------------------------------------------------- > > (Updated April 16, 2013, 2:53 a.m.) > > > Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, > and Min Chen. > > > Description > ------- > > Please refer to > https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements > for a background on the requirements driving this patch. > > This patch hasn't been extensively tested yet, and I will update this request > with more info. I am uploading a first diff for initial review/comments. > > > This addresses bug CLOUDSTACK-1086. > > > Diffs > ----- > > api/src/com/cloud/vm/UserVmService.java d963b74 > api/src/org/apache/cloudstack/api/BaseCmd.java 42c0680 > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 77ba9fe > core/src/com/cloud/vm/UserVmVO.java a16eaf9 > server/src/com/cloud/api/ApiDispatcher.java 925d90a > server/src/com/cloud/api/ApiServer.java d842819 > server/src/com/cloud/api/ApiServerService.java 12d8b52 > server/src/com/cloud/api/ApiServlet.java 03bfb5f > server/src/com/cloud/vm/UserVmManagerImpl.java d281e5b > server/test/com/cloud/vm/MockUserVmManagerImpl.java fd826d9 > server/test/com/cloud/vm/dao/UserVmDaoImplTest.java 0936180 > server/test/com/cloud/vm/dao/UserVmDaoTestConfiguration.java PRE-CREATION > server/test/resources/UserVMDaoTestContext.xml PRE-CREATION > setup/db/db/schema-410to420.sql fb760bf > tools/marvin/marvin/cloudstackConnection.py 1caeef3 > > Diff: https://reviews.apache.org/r/10294/diff/ > > > Testing > ------- > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
