Ilya, the review has not posted cleanly. Can you redo? On 4/17/13 5:07 PM, "Musayev, Ilya" <[email protected]> wrote:
>Chiradeep, > >Since you may have been the original writer of this logic, I've made some >changes that should improve and fix some problems we've witnessed. > >Please review and let me know if you see any issues. > >Thanks >ilya > >> -----Original Message----- >> From: ilya musayev [mailto:[email protected]] On Behalf Of ilya >> musayev >> Sent: Wednesday, April 17, 2013 8:00 PM >> To: Chiradeep Vittal >> Cc: ilya musayev; cloudstack >> Subject: Re: Review Request: CLOUDSTACK-2053: fixed if/else logic to >> address redundant entires, fixed boto/cloud-init support by adding >>metadata >> rewrite rule >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/10594/ >> ----------------------------------------------------------- >> >> (Updated April 18, 2013, midnight) >> >> >> Review request for cloudstack and Chiradeep Vittal. >> >> >> Description (updated) >> ------- >> >> Addressed 2 issues: >> Rewrote the bash if/else check to fix redundant entries Added >>RewriteRules >> to support boto/cloud-init - as per Chiradeep - this would only affect >> VMWare deployments, as this userdata.sh script is only used with vmware >> system router vms >> >> Noticed issue in the logic due to my initial misunderstanding of the >>process, >> fixed it with second commit. >> >> >> This addresses bug CLOUDSTACK-2053. >> >> >> Diffs (updated) >> ----- >> >> patches/systemvm/debian/config/root/userdata.sh e5d170b >> patches/systemvm/debian/config/root/userdata.sh e5d170b >> >> Diff: https://reviews.apache.org/r/10594/diff/ >> >> >> Testing >> ------- >> >> 4.1 >> >> >> Thanks, >> >> ilya musayev >
