----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10623/ -----------------------------------------------------------
Review request for cloudstack and Chip Childers. Description ------- createVolume changes the volume state from 'Allocated' to 'Creating', but has no code to change it back to 'Allocated' if anything goes wrong, despite there already being a path from 'Creating' to 'Allocated' for volumes, via the OperationFailed event. Adding this in fixes the issue and avoids leaving disks in an unusable state. This addresses bug CLOUDSTACK-2104. Diffs ----- server/src/com/cloud/storage/StorageManagerImpl.java 624361f Diff: https://reviews.apache.org/r/10623/diff/ Testing ------- Tested in devcloud-kvm, volume that was larger than primary storage failed to attack, and went back to 'Allocated' from 'Creating' upon the failure. I was then able to retry, and delete the disk. Thanks, Marcus Sorensen
