> On April 25, 2013, 8:55 a.m., Harikrishna Patnala wrote:
> > Ship It!
Not a right time to give comments but came across a difference when comparing
with my patch on master. we need to load vm details "_vmDao.loadDetails(vm)"
before getting the details "vm.getDetail("SSH.PublicKey")". since details are
transient.
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review19694
-----------------------------------------------------------
On April 2, 2013, 1:24 p.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
>
> (Updated April 2, 2013, 1:24 p.m.)
>
>
> Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.
>
>
> Description
> -------
>
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
>
> This patch add a new password in the response.
>
>
> This addresses bug CLOUDSTACK-1325.
>
>
> Diffs
> -----
>
> api/src/com/cloud/vm/UserVmService.java 6635657
> server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8
>
> Diff: https://reviews.apache.org/r/9539/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
>
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
> public $jobid =>
> string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
>
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
> public $password =>
> string(9) "mD5qkzmdk"
>
>
> Thanks,
>
> Wei Zhou
>
>
