-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10845/#review19920
-----------------------------------------------------------
Fang,
TemplateAdapter interface is a common adapter interface shared by all
hypervisors, therefore anything here would be as common as possible and this
will help us maintain a consistent semantics across hypervisors, the newly
added method
public boolean prepareOVAPacking(TemplateProfile profile);
is primarily used only by VMware hypervisor.
Since this VMware-specific step is triggered in responding a commonad command
public TemplateProfile prepareExtractTemplate(ExtractTemplateCmd cmd);
I would suggest you to hide OVA packing step inside it instead of changing the
semantic of the interface. This interface change breaks bare-metal build
- Kelven Yang
On April 29, 2013, 11:31 p.m., Fang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10845/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 11:31 p.m.)
>
>
> Review request for cloudstack and Kelven Yang.
>
>
> Description
> -------
>
> Somehow the previous patch did not include the changed files, only the four
> new files. This patch includes the changed files.
>
>
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-671.
>
>
> Diffs
> -----
>
>
> api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java
> 95d7659
> core/src/com/cloud/storage/resource/StoragePoolResource.java 5d352b0
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
> ee1b324
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManager.java
> a2e517d
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
> 1f11645
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> 99ad1ca
>
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java
> ce42f67
> server/src/com/cloud/server/ManagementServerImpl.java 16127a2
> server/src/com/cloud/template/HypervisorTemplateAdapter.java 491900b
> server/src/com/cloud/template/TemplateAdapter.java 1f8f491
> server/src/com/cloud/template/TemplateAdapterBase.java 1b11425
> server/src/com/cloud/template/TemplateManagerImpl.java c7eaa64
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
> 4503349
>
> Diff: https://reviews.apache.org/r/10845/diff/
>
>
> Testing
> -------
>
> Done as described in previous patch.
>
>
> Thanks,
>
> Fang Wang
>
>
