----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10572/#review20057 -----------------------------------------------------------
Ship it! commit 16865014a05ab04bb608a8122a7229b2b0ae3421 Author: Rajesh Battala <rajesh.batt...@citrix.com> Date: Wed Apr 17 18:22:30 2013 +0530 - Murali Reddy On April 17, 2013, 1:20 p.m., Rajesh Battala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10572/ > ----------------------------------------------------------- > > (Updated April 17, 2013, 1:20 p.m.) > > > Review request for cloudstack, Murali Reddy, Vijay Venkatachalam, and Ram > Ganesh. > > > Description > ------- > > Fixed the issue > 1.While creating the LB rule, healthcheck policies were not sent, so they are > not getting created. Fixed the issue by including them in TO constructor. > 2. Fetching the status of healthchecks created in basic zone. > > > This addresses bug CLOUDSTACK-1851. > > > Diffs > ----- > > > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java > 2bbdb04 > > Diff: https://reviews.apache.org/r/10572/diff/ > > > Testing > ------- > > Created basiczone setup with Netscaler. > > 1. Verified creation/deletion of healthchecks on LB rules > 2. Verified creation of healthchecks with different param values. > 3. Verified the Healthcheck manager is updating the status of the services in > the lb vm map table. > 4. Verified deletion of healthchecks, resetting the status of services to null > 5. Deletion of healthcheck will do clean up of healthcheck entires in > cloudstack db and in Netscaler resource. > > > Thanks, > > Rajesh Battala > >
