> On May 6, 2013, 6:03 a.m., Prasanna Santhanam wrote: > > Does this also fix CLOUDSTACK-1309?
No, I think it will not work in some issue. If we have too much ips in a subnet(Class A or B), stack will check everyone and add free ips to a set. It will cause OOM when the set is too big. So I changed it, the list has 255 members as most now. But if we have several big wide subnet, and most ips in the subnet are already used, the stack will also check all ips to find out which are not used. It won't cause OOM but it will take too long time also. - Hongtu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10750/#review20177 ----------------------------------------------------------- On April 24, 2013, 4:20 a.m., Hongtu Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10750/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 4:20 a.m.) > > > Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and mice > xia. > > > Description > ------- > > fix bug CLOUDSTACK-2160: add a huge size guest network will cause out of > memory > > modify NetUtils.java getAllIpsFromCidr, it will returns no more than 255 > unused ips. > > > This addresses bug CLOUDSTACK-2160. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkModelImpl.java c5930d9 > server/src/com/cloud/network/NetworkServiceImpl.java ac2ac45 > utils/src/com/cloud/utils/net/NetUtils.java 5988dd5 > > Diff: https://reviews.apache.org/r/10750/diff/ > > > Testing > ------- > > create a new network with netmask 255.0.0.0 and it won't cause out of memory > > > Thanks, > > Hongtu Zang > >
