----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10957/#review20214 -----------------------------------------------------------
Commit b02bbc841e0ca927b5e208c394dbc8631bb1c389 in branch refs/heads/4.1 from Chip Childers <chip.child...@gmail.com> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=b02bbc8 ] CLOUDSTACK-2319: fix "unable to add egress rules" in SecurityGroup Signed-off-by: Chip Childers <chip.child...@gmail.com> - ASF Subversion and Git Services On May 6, 2013, 6:44 p.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10957/ > ----------------------------------------------------------- > > (Updated May 6, 2013, 6:44 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > This patch changes: > (1) CloudStack UI (egress rule in Security Group) > (2) findByUuidIncludingRemoved(uuid) return security_group_rule.id (find by > security_group_rule.uuid) instead of security_group.id (find by > security_group.uuid) > > > This addresses bug CLOUDSTACK-2319. > > > Diffs > ----- > > api/src/com/cloud/network/security/SecurityGroupRules.java d255e46 > core/src/com/cloud/network/security/SecurityGroupRulesVO.java 82060ef > server/src/com/cloud/network/security/dao/SecurityGroupRulesDaoImpl.java > f08ca05 > ui/scripts/network.js 1bc4eba > > Diff: https://reviews.apache.org/r/10957/diff/ > > > Testing > ------- > > Testing ok. > > > Thanks, > > Wei Zhou > >
