----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10955/#review20222 -----------------------------------------------------------
Ship it! Ship It! - Chip Childers On May 6, 2013, 6:08 p.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10955/ > ----------------------------------------------------------- > > (Updated May 6, 2013, 6:08 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > The allocateDirectIp in NetworkManagerImpl.java changes after ipv6 support. > Two sentences were added before assignPublicIP. > (1) if (network.getGateway() != null) > (2) if (network.getIp6Gateway() != null) { > However, for Shared Network, both fields are null in table `cloud`.`networks`. > Some fields in table `cloud`.`networks` need to be updated. > > > This addresses bug CLOUDSTACK-2322. > > > Diffs > ----- > > setup/db/db/schema-40to410.sql fe53d36 > > Diff: https://reviews.apache.org/r/10955/diff/ > > > Testing > ------- > > Testing ok. > > > Thanks, > > Wei Zhou > >
