----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11176/#review20571 -----------------------------------------------------------
Ship it! commit 9b6513466f5826d4932bf69dcf3a531f05ac625c - Kishan Kavala On May 15, 2013, 10:14 a.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11176/ > ----------------------------------------------------------- > > (Updated May 15, 2013, 10:14 a.m.) > > > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, Murali > Reddy, and Alena Prokharchyk. > > > Description > ------- > > Fixed adding same private gateway twice. > Fixed by not allowing same vlan/network twice. > > > This addresses bug CLOUDSTACK-2369. > > > Diffs > ----- > > engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDao.java 02df92e > engine/schema/src/com/cloud/network/vpc/dao/PrivateIpDaoImpl.java ecab3bb > server/src/com/cloud/network/NetworkServiceImpl.java f3ec253 > > Diff: https://reviews.apache.org/r/11176/diff/ > > > Testing > ------- > > 1. created new deployment, and added vpc > 2. added same private gateway twice. > 3. configuring gateway second time failed > > > Thanks, > > Jayapal Reddy > >
