----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11437/#review21078 -----------------------------------------------------------
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java <https://reviews.apache.org/r/11437/#comment43590> Please put a comment as to the need for this extra '-'. In case you are doing this to handle any boundary condition explain that as well. patches/systemvm/debian/config/root/deleteIpAlias.sh <https://reviews.apache.org/r/11437/#comment43592> Plese review the condition. Do you need both checks? server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11437/#comment43595> dhco -> dhcp, also should be revoke server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11437/#comment43593> The message says apply, should be revoke. - Koushik Das On May 27, 2013, 3:23 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11437/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 3:23 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Reboot or start/stop router vm deletes the ip alises > created on VR in case of multiple subnets > https://issues.apache.org/jira/browse/CLOUDSTACK-2648 > > > This addresses bug Cloudstack-2648. > > > Diffs > ----- > > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 8b996d1 > patches/systemvm/debian/config/root/deleteIpAlias.sh 865ff3b > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 630d1b4 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 4680fde > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > b969be2 > > Diff: https://reviews.apache.org/r/11437/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
