> On May 28, 2013, 9:58 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 382 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line382> > > > > Even the root disk snapshots are deleted. > > And since the VM will be successfully moved if both the domains are > > under the same domain admin shouldn't the test condition change?
Yes as root disk snapshots are also deleted. I have added assert for snapshot check and removed the assertRaise > On May 28, 2013, 9:58 a.m., Likitha Shetty wrote: > > test/integration/component/test_assign_vm.py, line 404 > > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line404> > > > > Oh that makes sense. > > > > If the resource type is snapshot shouldn't the value of resourceType > > parameter be '3' for updateResourceLimit API? > > I am a little confused. So the test case is that we reduce the snapshot > > resource limit of subdomain2 to 1 and try to move a VM with 1 snapshot to > > subdomain1? Right, but now since as you have mentioned both ROOT and DATA_DISKS snapshots are deleted once VM owner is changed, this limit condition will not work. I have updated the test to check for number of instances and max instance is set to 0. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11307/#review21084 ----------------------------------------------------------- On May 28, 2013, 9:45 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11307/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 9:45 a.m.) > > > Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth > Jagirdar, and Girish Shilamkar. > > > Description > ------- > > Testcases for changing account membership for vas > > > This addresses bug CLOUDSTACK-2273. > > > Diffs > ----- > > test/integration/component/test_assign_vm.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py f3a96bd > > Diff: https://reviews.apache.org/r/11307/diff/ > > > Testing > ------- > > > Thanks, > > Ashutosh Kelkar > >
