thanks fellows, It is clear to me, what hte problem and the course to take is. I will report more on it tomorrow
regards, Daan On Tue, May 28, 2013 at 8:35 PM, Alex Huang <alex.hu...@citrix.com> wrote: > Unit tests are ran in random order because each unit test should be > self-sufficient. I'm saying I've seen cases where unit tests aren't > written to be self-sufficient and that's why an unit test fails sometimes > and passes sometimes. > > In those cases, we should fix the unit test and not the order. A common > problem is sharing the mocked classes. For example, unit test A tests the > set of a mock object and unit test B tests if the field is null but they > shared the mock instance. In this case, unit test B passes if it is ran > before unit test A but fails if it was ran after. > > But often times the randomness of how it's ran is actually pseudo-random > so it works consistently on someone's laptop but as soon as it gets ran on > another machine, the order changes and it fails. So when you see the > problem such as this, you should always let the unit test writer know the > order in which the unit tests were executed so that the unit test writer > can try it. > > --Alex > > > -----Original Message----- > > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > > Sent: Monday, May 27, 2013 9:23 AM > > To: dev@cloudstack.apache.org > > Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > > > And if not how do I manipulate the order of tests? > > > > -----Original Message----- > > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > > Sent: maandag 27 mei 2013 17:02 > > To: dev@cloudstack.apache.org > > Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > > > Alex, > > > > Can this change out of the box? I had the problem on a clean checkout of > > master. > > > > -----Original Message----- > > From: Alex Huang [mailto:alex.hu...@citrix.com] > > Sent: maandag 27 mei 2013 15:55 > > To: dev@cloudstack.apache.org > > Subject: RE: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > > > Daan, > > > > The other possibility is that the test is affected by another test so > that it > > breaks when the tests are in a certain order. Have you noticed what's > the > > order of the tests ran when it breaks? > > > > --Alex > > > > > -----Original Message----- > > > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > > > Sent: Monday, May 27, 2013 2:37 AM > > > To: dev@cloudstack.apache.org > > > Subject: RE: master build breaks at > > > com.cloud.vpc.NetworkACLServiceTest > > > > > > Being in the habit of replying on my own mails as I seems to be on > > > this list; > > > > > > This seems to be related to eclipse refresh/build code. Does anybody > > > have a solution to it? The problem is not consistently present but all > > > the more irritating. > > > > > > Regards, > > > > > > -----Original Message----- > > > From: Daan Hoogland [mailto:dhoogl...@schubergphilis.com] > > > Sent: maandag 27 mei 2013 7:49 > > > To: dev@cloudstack.apache.org > > > Subject: master build breaks at com.cloud.vpc.NetworkACLServiceTest > > > > > > LS, > > > > > > Lately I've been getting, > > > "com.cloud.exception.InvalidParameterValueException: ACL item with > > > number 1 already exists in ACL: null", while building cloudstack. I > > > first thought it was my own hack so I don't know when it was > > > introduced (it is in a clean master that it happens). The full surfire > report > > follows: > > > > > > ---------------------------------------------------------------------- > > > --------- Test set: com.cloud.vpc.NetworkACLServiceTest > > > ---------------------------------------------------------------------- > > > --------- Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time > > > elapsed: 0.219 sec <<< FAILURE! > > > testCreateACLItem(com.cloud.vpc.NetworkACLServiceTest) Time elapsed: > > > 0.016 sec <<< ERROR! > > > com.cloud.exception.InvalidParameterValueException: ACL item with > > > number 1 already exists in ACL: null > > > at > > > > > com.cloud.network.vpc.NetworkACLServiceImpl.createNetworkACLItem(Ne > > > tworkACLServiceImpl.java:270) > > > at > > > > > com.cloud.vpc.NetworkACLServiceTest.testCreateACLItem(NetworkACLServ > > > iceTest.java:141) > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown > Source) > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > > > Source) > > > at java.lang.reflect.Method.invoke(Unknown Source) > > > at > > > > > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framework > > > Method.java:45) > > > at > > > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCall > > > able.jav > > > a:15) > > > at > > > org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework > > > Method.java:42) > > > at > > > > > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMeth > > > od.java:20) > > > at > > > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.j > > > ava > > > :28) > > > at > > > > > org.springframework.test.context.junit4.statements.RunBeforeTestMethod > > > Callbacks.evaluate(RunBeforeTestMethodCallbacks.java:74) > > > at > > > > > org.springframework.test.context.junit4.statements.RunAfterTestMethodC > > > allbacks.evaluate(RunAfterTestMethodCallbacks.java:83) > > > at > > > org.springframework.test.context.junit4.statements.SpringRepeat.evalua > > > te( > > > SpringRepeat.java:72) > > > at > > > org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChi > > > ld(S > > > pringJUnit4ClassRunner.java:231) > > > at > > > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunn > > > er.j > > > ava:47) > > > at > org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > > > at > org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > > > at > > org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > > > at > org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > > > at > > org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > > > at > > > org.springframework.test.context.junit4.statements.RunBeforeTestClassC > > > all > > > backs.evaluate(RunBeforeTestClassCallbacks.java:61) > > > at > > > org.springframework.test.context.junit4.statements.RunAfterTestClassCa > > > llb > > > acks.evaluate(RunAfterTestClassCallbacks.java:71) > > > at > org.junit.runners.ParentRunner.run(ParentRunner.java:300) > > > at > > > org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(Sp > > > ring > > > JUnit4ClassRunner.java:174) > > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider > > > .jav > > > a:236) > > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4P > > > rov > > > ider.java:134) > > > at > > > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider. > > > java > > > :113) > > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > > > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown > Source) > > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > > > Source) > > > at java.lang.reflect.Method.invoke(Unknown Source) > > > at > > > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(R > > > efl > > > ectionUtils.java:189) > > > at > > > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke( > > > Pr > > > oviderFactory.java:165) > > > at > > > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(Provid > > > er > > > Factory.java:85) > > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(Forke > > > d > > > Booter.java:103) > > > at > > > > > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:7 > > > 4) >
