Sounds reasonable So, anyways, I left them both in my patch file since I figured we could resolve this later (obviously only the second "volumes" view is really being used anyways).
On Thu, May 30, 2013 at 11:00 AM, Min Chen <min.c...@citrix.com> wrote: > The reason is simple, just two people are trying to change that view for > their own features, but didn't check if there is one already in that script > to modify that instead of creating their own. > > Thanks > -min > > > > From: Mike Tutkowski <mike.tutkow...@solidfire.com> > Date: Thursday, May 30, 2013 9:58 AM > To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org> > Cc: Min Chen <min.c...@citrix.com> > Subject: Re: Create View Question > > Hi Nitin, > > I left both of the "volumes" views in the codebase when I submitted my > patch for review. > > Just curious, though...can you tell me why there are two places where > the view is created? > > Thanks! > > > On Thu, May 30, 2013 at 7:46 AM, Nitin Mehta <nitin.me...@citrix.com>wrote: > >> Sorry for missing the mail. I would need the new volume view for my >> feature to work. >> >> On 24/05/13 1:45 AM, "Min Chen" <min.c...@citrix.com> wrote: >> >> >It is related to this commit d1642a489ce76e055d60b2caf3ccfe4bb136b745. >> >Schema-410to420.sql should have one section to define the new volume_view >> >for 4.2.0. >> >CC Nitin here to see if his new volume_view should be used or the one >> >before his commit in this file. >> > >> >THanks >> >-min >> > >> > >> >On 5/23/13 12:50 PM, "Mike Tutkowski" <mike.tutkow...@solidfire.com> >> >wrote: >> > >> >>Hi, >> >> >> >>I've added a few fields (min, max, burst IOPS) to two tables and - in >> the >> >>process - noticed the following view is dropped and created twice: >> >> >> >>DROP VIEW IF EXISTS `cloud`.`volume_view`; >> >>CREATE VIEW `cloud`.`volume_view` AS >> >> >> >>I assume this is a bug and have removed (in my sandbox) the >> >>first occurrence. >> >> >> >>If anyone knows of a reason why we want to keep this code as is, please >> >>let >> >>me know as this change will otherwise be submitted when I submit my code >> >>for review tomorrow or early next week. >> >> >> >>Thanks! >> >> >> >>-- >> >>*Mike Tutkowski* >> >>*Senior CloudStack Developer, SolidFire Inc.* >> >>e: mike.tutkow...@solidfire.com >> >>o: 303.746.7302 >> >>Advancing the way the world uses the >> >>cloud<http://solidfire.com/solution/overview/?video=play> >> >>* * >> > >> >> > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkow...@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the > cloud<http://solidfire.com/solution/overview/?video=play> > *™* > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud<http://solidfire.com/solution/overview/?video=play> *™*
