Also, we already released 4.1.0.  If this is needed, how should it be
correctly done for a 4.1.1 release?


On Tue, Jun 04, 2013 at 05:03:49PM +0000, Chiradeep Vittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11627/#review21422
> -----------------------------------------------------------
> 
> 
> 
> engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java
> <https://reviews.apache.org/r/11627/#comment44357>
> 
>     The logic is not clear. Can you add a few comments and logs as to WHY the 
> system vm password is being updated?
> 
> 
> - Chiradeep Vittal
> 
> 
> On June 4, 2013, 12:53 p.m., Saksham Srivastava wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/11627/
> > -----------------------------------------------------------
> > 
> > (Updated June 4, 2013, 12:53 p.m.)
> > 
> > 
> > Review request for cloudstack and Kishan Kavala.
> > 
> > 
> > Description
> > -------
> > 
> > Encrypt system.vm.password and make the configuration as Secure.
> > 
> > 
> > This addresses bug CLOUDSTACK-1012.
> > 
> > 
> > Diffs
> > -----
> > 
> >   engine/schema/src/com/cloud/upgrade/dao/Upgrade40to41.java 9e386b9 
> > 
> > Diff: https://reviews.apache.org/r/11627/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Tested on local setup.
> > Build successful.
> > 
> > 
> > Thanks,
> > 
> > Saksham Srivastava
> > 
> >
> 

Reply via email to