> On June 5, 2013, 8:34 a.m., Devdeep Singh wrote: > > Ship It!
Committed the changes. Commit id: 4da995238b0f4b9d4109afaa505e9213e07486f5. Kindly close the review request - Devdeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11564/#review21470 ----------------------------------------------------------- On May 31, 2013, 9:05 a.m., SrikanteswaraRao Talluri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11564/ > ----------------------------------------------------------- > > (Updated May 31, 2013, 9:05 a.m.) > > > Review request for cloudstack, Devdeep Singh, Prasanna Santhanam, and Koushik > Das. > > > Description > ------- > > CLOUDSTACK-2783: FIXED listHypervisorCapabilities API response to include > the following fields: > 1. maxdatavolumes > 2. maxhostspercluster > 3. storagemotionenabled > > > This addresses bug CLOUDSTACK-2783. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/ApiConstants.java 1e9435f > > api/src/org/apache/cloudstack/api/response/HypervisorCapabilitiesResponse.java > 3602187 > server/src/com/cloud/api/ApiResponseHelper.java 7e8eda0 > > Diff: https://reviews.apache.org/r/11564/diff/ > > > Testing > ------- > > API response after fix: > > <hypervisorCapabilities> > <id>2e077902-c9ce-11e2-a714-848611c5a6f1</id> > <hypervisorversion>6.1.0</hypervisorversion> > <hypervisor>XenServer</hypervisor> > <maxguestslimit>50</maxguestslimit> > <securitygroupenabled>true</securitygroupenabled> > <maxdatavolumeslimit>13</maxdatavolumeslimit> > <storagemotionenabled>true</storagemotionenabled> > </hypervisorCapabilities> > <hypervisorCapabilities> > <id>2e0783e8-c9ce-11e2-a714-848611c5a6f1</id> > <hypervisorversion>5.1</hypervisorversion> > <hypervisor>VMware</hypervisor> > <maxguestslimit>128</maxguestslimit> > <securitygroupenabled>false</securitygroupenabled> > <maxdatavolumeslimit>6</maxdatavolumeslimit> > <maxhostspercluster>32</maxhostspercluster> > <storagemotionenabled>false</storagemotionenabled> > </hypervisorCapabilities> > > > Thanks, > > SrikanteswaraRao Talluri > >
