----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11623/#review21474 -----------------------------------------------------------
Ship it! Changes look fine. Committed to master. - Devdeep Singh On June 4, 2013, 8:13 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11623/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 8:13 a.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Description > ------- > > CLOUDSTACK-2824: API:MS:Ability to delete events and alerts-Auto Purge for > Alerts doesn't work > > > This addresses bug CLOUDSTACK-2824. > > > Diffs > ----- > > engine/schema/src/com/cloud/alert/dao/AlertDaoImpl.java 01a560a > > Diff: https://reviews.apache.org/r/11623/diff/ > > > Testing > ------- > > Tests: > > 1. Set alert.purge.delay = 1 > 2. Set alert.purge.interval = 120 sec > 3. Restart MS > 4. Verified from DB entries that alerts are getting purged > > > Thanks, > > Sanjay Tripathi > >
