----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11780/#review21785 -----------------------------------------------------------
Ship it! Ship It! - Abhinandan Prateek On June 10, 2013, 5:19 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11780/ > ----------------------------------------------------------- > > (Updated June 10, 2013, 5:19 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Description > ------- > > Global parameter "cluster.memory.allocated.capacity.disablethreshold" and > "cluster.cpu.allocated.capacity.disablethreshold" are not disabling cluster > after threshold values. > > This is due to unhandled sql query when these parameters have null values in > the DB. Fixed by adding that case in the query. > > > This addresses bugs CLOUDSTACK-1622 and CLOUDSTACK-1704. > > > Diffs > ----- > > engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java 0b9ff1a > > Diff: https://reviews.apache.org/r/11780/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Harikrishna Patnala > >
