-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11874/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

Issue: .There are two ssvm_check scripts(duplicates).

./services/console-proxy/server/scripts/ssvm-check.sh
./services/secondary-storage/scripts/ssvm-check.sh

When building the code, these scripts will go to systemvm.zip, systemvm.zip 
will be packaged into systemvm.iso. 

systemvm-descriptor.xml will define what all the scripts should package.
As per the descriptor xml,  the ssvm-check script under console-proxy is 
getting into systemvm.zip.

I had verified the ssvm-check script with the fix under console-proxy. The 
systemvm.zip is getting update properly and making into systemvm.iso.
And ssvm is getting the right script now.

Changes made in script under ./services/secondary-storage/scripts/ssvm-check.sh 
is not getting into systemvm.iso

Fixed:
    Modified systemvm-descriptor.xml to pick the ssvm-check.sh form 
./services/secondary-storage/scripts/ssvm-check.sh
    removed the duplicate file which is creating confusion 
(./services/console-proxy/server/scripts/ssvm-check.sh)


This addresses bug CLOUDSTACK-3004.


Diffs
-----

  services/console-proxy/server/scripts/ssvm-check.sh 7b83c98 
  services/console-proxy/server/systemvm-descriptor.xml e34026b 

Diff: https://reviews.apache.org/r/11874/diff/


Testing
-------

Tested by generating the systemvm.zip , the ssvm-check file is getting copied 
into the zip from the ./services/secondary-storage/scripts/ssvm-check.sh


Thanks,

Rajesh Battala

Reply via email to