----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11907/#review22106 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java <https://reviews.apache.org/r/11907/#comment45498> Minor: Hyp..CapabilitiesResponse import is not required here. - Abhinandan Prateek On June 18, 2013, 8:38 a.m., Ian Duffy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11907/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 8:38 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen. > > > Description > ------- > > CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not > appear. > > This bug occurred due to the UI expecting a "list" of ldap configurations > back from the API. > > I have modified the API command to return a "list" like format, but since > cloudstack only currently supports authentication against one ldap server it > will only return 1 configuration. > > Whoever takes up CLOUDSTACK-430 > https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for > multiple ldap servers will have to expand on this output. > > > This addresses bug CLOUDSTACK-2168. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java > 2726f84 > > Diff: https://reviews.apache.org/r/11907/diff/ > > > Testing > ------- > > Build the code with the changes, confirmed the API still returned the > expected results. > Confirmed that the UI showed the configuration. > > > Thanks, > > Ian Duffy > >
