----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11990/#review22164 -----------------------------------------------------------
server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/11990/#comment45562> A bit nit picky, but this feels like a CloudRuntimeException rather than pre-condition failure. Also, add the name/id of the VM and the ID of the ISO to the message to assist debugging efforts. - John Burwell On June 20, 2013, 10:12 a.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11990/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 10:12 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > refuse to destroy a vm when it has an iso mounted. This will prevent a tab > from remain as garbage on a hypervisor. > > > This addresses bug CLOUDSTACK-3092. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java 7ae96da > server/test/com/cloud/vm/UserVmManagerTest.java 5eedfa5 > > Diff: https://reviews.apache.org/r/11990/diff/ > > > Testing > ------- > > A unit test for the manager involved. It is included in the diff. > > > Thanks, > > daan Hoogland > >
