> On June 27, 2013, 6:36 p.m., edison su wrote:
> > engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java,
> > line 170
> > <https://reviews.apache.org/r/12131/diff/1/?file=312666#file312666line170>
> >
> >
> > In most of the cases(vmware/xen/kvm), must to have cache storage if S3
> > is used, in the current code. We can't say, if there is no cache storage
> > available in the system for those hypervisors, we should throw exception
> > immediately.
> >
> > Better to add code in needCacheStorage(), or subclass
> > ancientDataMotionStrategy for hyperV.
> >
> > For example, you can add following code in needcachestorage():
> >
> > if (srcData.getType() == DataObjectType.Template) {
> > TemplateInfo template = (TemplateInfo)srcData;
> > if (template.getHypervisorType() == HypervisorType.HperV) {
> > return false;
> > }
> > }
> > }
> >
> >
>
> Donal Lafferty wrote:
> Sure, what do you want to throw? E.g. what object type do you want to
> throw.
In StorageCacheManagerImpl->createCacheObject(DataObject data, Scope scope): we
should have the following code:
DataStore cacheStore = this.getCacheStorage(scope);
if (cacheStore == null) {
s_logger.debug(); throw new CloudRuntimeException("something");
}
- edison
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12131/#review22478
-----------------------------------------------------------
On June 27, 2013, 10:27 a.m., Donal Lafferty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12131/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 10:27 a.m.)
>
>
> Review request for cloudstack, edison su and Min Chen.
>
>
> Bugs: CLOUDSTACK-3215
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Fix https://issues.apache.org/jira/browse/CLOUDSTACK-3215 by changing code to
> not use a cache for image transfer if one can't be found. Previously, the
> management server entered a failure state.
> Also, added addition debug logging.
>
>
> Diffs
> -----
>
>
> engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java
> 4b4e52106ffbf70bcf2f6a656a8b8e4cacd6f91e
>
> engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
> 631de6a47a3eff510c84aa275fd87f8fa2f7780b
>
> Diff: https://reviews.apache.org/r/12131/diff/
>
>
> Testing
> -------
>
> Code executed on deployement using S3 and no NFS cache. Did not have
> facilities to test on S3 with a cache.
>
>
> Thanks,
>
> Donal Lafferty
>
>
