> On June 30, 2013, 6:50 a.m., Prasanna Santhanam wrote: > > Applying: CLOUDSTACK-2288: NPE while creating volume from snapshot when the > > primary storage is in maintenance state. > > error: patch failed: server/src/com/cloud/storage/VolumeManagerImpl.java:523 > > error: server/src/com/cloud/storage/VolumeManagerImpl.java: patch does not > > apply > > Patch failed at 0001 CLOUDSTACK-2288: NPE while creating volume from > > snapshot when the primary storage is in maintenance state. > > When you have resolved this problem run "git am --resolved". > > If you would prefer to skip this patch, instead run "git am --skip". > > To restore the original branch and stop patching run "git am --abort". > > > > Fails to apply because of storage related changes. Can you retest if this > > is still an issue and submit the patch? > > > > Thanks
The issue is still there in master so recreating the patch based on latest master code. - Sanjay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11670/#review22579 ----------------------------------------------------------- On June 6, 2013, 11:24 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11670/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 11:24 a.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Bugs: CLOUDSTACK-2288 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-2288: NPE while creating volume from snapshot when the primary > storage is in maintenance state. > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeManagerImpl.java 43f3681 > > Diff: https://reviews.apache.org/r/11670/diff/ > > > Testing > ------- > > Tests: > 1. In CS setup, put all primary storage in maintenance mode. > 2. Create a volume from snapshot. > > Verified the fix locally. > > > Thanks, > > Sanjay Tripathi > >
