----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11953/#review22615 -----------------------------------------------------------
Ship it! This change looks good, we can remove this part for now. Some background about this code: Originaly the design was to pass down the poolId from the reservation via the DeploymentPlan to the DeploymentPlanners to use. However we need some refactoring around this code to be able to pass multiple pool information in case a VM has multiple Volumes. Until then we will let the planners figure out the pools to use for deployment always, so passing the poolId null for now. - Prachi Damle On June 30, 2013, 5:52 a.m., Dave Brosius wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11953/ > ----------------------------------------------------------- > > (Updated June 30, 2013, 5:52 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Prachi Damle. > > > Repository: cloudstack-git > > > Description > ------- > > remove code that may have been used for something in the past, but now does > nothing but allocate memory temporarily. > > > Diffs > ----- > > > engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java > 38ed7e6 > > Diff: https://reviews.apache.org/r/11953/diff/ > > > Testing > ------- > > > Thanks, > > Dave Brosius > >
