> On June 29, 2013, 7:24 a.m., Sateesh Chodapuneedi wrote: > > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java, > > line 61 > > <https://reviews.apache.org/r/12180/diff/1/?file=313061#file313061line61> > > > > LGTM. > > Can you also add datastore id in the log message. It's useful to know > > the datastore that is not found.
The datastore id getting passed here is the db id and not the uuid.. since it won't be found anyway, will it still be useful to put it in there? I have put it in in the latest patch, and this is how the error looks now: ERROR [cloud.api.ApiServer] (839949122@qtp-1814078009-2:) unhandled exception executing api command: createStoragePool com.cloud.utils.exception.CloudRuntimeException: Unable to locate datastore with id 3 - Venkata Siva Vijayendra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12180/#review22562 ----------------------------------------------------------- On July 3, 2013, 12:25 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12180/ > ----------------------------------------------------------- > > (Updated July 3, 2013, 12:25 a.m.) > > > Review request for cloudstack, Chip Childers, Devdeep Singh, Kelven Yang, and > Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-3110 > > > Repository: cloudstack-git > > > Description > ------- > > Fixing an NPE when an attempt is made to add a primary datastore by providing > an unreachable/nonexistent datastore/host. > > > Diffs > ----- > > > engine/storage/src/org/apache/cloudstack/storage/datastore/DataStoreManagerImpl.java > 71df262 > > engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/PrimaryDataStoreProviderManagerImpl.java > 06b54e0 > > Diff: https://reviews.apache.org/r/12180/diff/ > > > Testing > ------- > > With fix in place, an attempt to add an invalid primary datastore will fail > with a GUI error dialog instead of failing silently with an NPE in the mgmt > server log. > > > File Attachments > ---------------- > > Refactored patch for master-6-17-stable branch > > https://reviews.apache.org/media/uploaded/files/2013/06/29/0001-CLOUDSTACK-3110-VMWARE-NPE-while-adding-primary-stor.patch > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
