----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/ -----------------------------------------------------------
(Updated July 4, 2013, 2:09 a.m.) Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and Sheng Yang. Changes ------- Sheng commented on the issue that we are calling the function configDhcpSupportForSubnet for all dhcp service providers even if they do not support multiple subnets. This will cause the dhcp config to fail in cases which do not support this feature. I fixed this by adding the dhcpservice across multiple subnets as a capability of the virtualrouter's dhcp service, introduced a check before adding a new subnet and also before calling the configDhcpSupportForSubnet. Repository: cloudstack-git Description ------- Incorporating the review comments given by Alena and Sheng. Diffs (updated) ----- api/src/com/cloud/network/Network.java a06208b api/src/com/cloud/network/NetworkService.java 405cecd server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 server/src/com/cloud/network/NetworkManagerImpl.java 708c03d server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde server/src/com/cloud/network/element/VirtualRouterElement.java 1916678 server/test/com/cloud/network/MockNetworkManagerImpl.java 077395f server/test/com/cloud/vpc/MockNetworkManagerImpl.java b609022 Diff: https://reviews.apache.org/r/12251/diff/ Testing ------- Thanks, bharat kumar
