----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12278/#review22807 -----------------------------------------------------------
Commit 814630c5428862aa247914e5bc04c3bcbc00c501 in branch refs/heads/master from toshiaki.hatano [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=814630c ] CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be 0-'4095'. - ASF Subversion and Git Services On July 5, 2013, 8:14 p.m., Toshiaki Hatano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12278/ > ----------------------------------------------------------- > > (Updated July 5, 2013, 8:14 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, Chiradeep Vittal, Murali > Reddy, Hugo Trippaers, and Sheng Yang. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3384 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3384: CloudStack allow VLAN range between 0-4096. Should be > 0-'4095'. > > There're VLAN range check code in com.cloud.network.NetworkServiceImpl. > But it allows VLAN range between 0-4096. > > VLAN ID have 12 bit field and it's between 0-4095 (0x000 - 0xFFF) . > CloudStack should return error when someone try to assign VLAN ID 4096 to > network. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java 05df742 > > Diff: https://reviews.apache.org/r/12278/diff/ > > > Testing > ------- > > Trying to create zone with Guest VLAN range 4090-4096 from WebUI. > > updatePhysicalNetwork returns error correctly. > > > Thanks, > > Toshiaki Hatano > >
