-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11858/
-----------------------------------------------------------
(Updated July 10, 2013, 12:37 p.m.)
Review request for cloudstack, Alena Prokharchyk, Murali Reddy, Ram Ganesh, and
Sateesh Chodapuneedi.
Changes
-------
Rebased with latest head and tested the patch
Bugs: CLOUDSTACK-2340
Repository: cloudstack-git
Description
-------
Issue: when healthcheck is created for LB rule then
listLoadBalancerRuleInstance api should have the service state populated by
LBHealthCheckManager.
Fixed: Fixed the response of listLoadBalancerRuleInstance to include a
"servicestate":"UP" which tell the service state of the instance.
if the healthcheck is not created on LB then api response then
"servicestate" field won't be in the response.
Diffs (updated)
-----
api/src/com/cloud/network/lb/LoadBalancingRulesService.java 5fc41e3
api/src/org/apache/cloudstack/api/ApiConstants.java e2857b8
api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListLoadBalancerRuleInstancesCmd.java
49ab42c
api/src/org/apache/cloudstack/api/response/UserVmResponse.java 0df9413
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 6e0d0d7
Diff: https://reviews.apache.org/r/11858/diff/
Testing
-------
1. Created LB rule with healthcheck policy verified the
listLoadBalancerRuleInstance api response, it has the field servicestate for
all the VM's assigned to the LB rule
2. Created LB rule without healthcheck policy, verified the
listLoadBalancerRuleInstance api response wont have the servicestate field for
all the VM's assigned to the LB rule
Thanks,
Rajesh Battala
