Results of our bad git habits I think: The original commit by Hongtu made the full fix but it probably got messed up in some merge later. :/
We need to look into the resize volume test that exists in the smoke tests. Rayees, since run vmware environments internally for Citrix - has the resize test been consistently passing on vmware before this fix? On Sat, Jul 13, 2013 at 11:31:52AM +0530, Prasanna Santhanam wrote: > To update the thread: > > Vijay filed CLOUDSTACK-3509 for the missing support for vmware and > identified the commit for the vmware support in CLOUDSTACK-644. So > the review was submitted but had a different author which is why we > failed to find it the last time. > > This should be good now after Vijay's fix. > > On Wed, Jul 10, 2013 at 05:21:09AM +0000, Srikanteswararao Talluri wrote: > > Is there any update on this check in ? Is some one taking a look at this > > missing feature? > > > > Thanks, > > ~Talluri > > > > On 03/07/13 10:50 PM, "Animesh Chaturvedi" <animesh.chaturv...@citrix.com> > > wrote: > > > > >I see the review request https://reviews.apache.org/r/9241/ is marked as > > >submitted on 2/7 but don't see the changes > > > > > > > > >Animesh > > > > > >> -----Original Message----- > > >> From: Sudha Ponnaganti [mailto:sudha.ponnaga...@citrix.com] > > >> Sent: Wednesday, July 03, 2013 9:51 AM > > >> To: dev@cloudstack.apache.org > > >> Cc: Mice Xia; Marcus Sorensen; hongtu_z...@tcloudcomputing.com > > >> Subject: RE: disk resize support on VMWare > > >> > > >> Can someone shed some light on this missing feature?? > > >> > > >> -----Original Message----- > > >> From: Prasanna Santhanam [mailto:t...@apache.org] > > >> Sent: Wednesday, July 03, 2013 7:13 AM > > >> To: dev@cloudstack.apache.org > > >> Cc: Mice Xia; Marcus Sorensen; hongtu_z...@tcloudcomputing.com > > >> Subject: Re: disk resize support on VMWare > > >> > > >> On Wed, Jul 03, 2013 at 06:46:54AM +0000, Srikanteswararao Talluri > > >> wrote: > > >> > I am not able to find whether this review request has been submitted > > >> > to master https://reviews.apache.org/r/9241/ . I could not find the > > >> > code changes in the latest master. Did I miss anything here? > > >> > > > >> > > >> I don't see anything related to disk resize in the authors git log. > > >> Wasn't applied I guess. > > >> > > >> > > >> -- > > >> Prasanna., > > >> > > >> ------------------------ > > >> Powered by BigRock.com > > > > > -- > Prasanna., > > ------------------------ > Powered by BigRock.com -- Prasanna., ------------------------ Powered by BigRock.com
