> On July 15, 2013, 8:30 a.m., Hugo Trippaers wrote: > > Ship It!
master: 1f004f60e8542b7e6f75a780b59ad738161f7346 4.2: 6e85ae219b53a1350eff3914922fac4b8d3e5a40 I made a minor change. I kept nicNum outside the if statement as the numbering needs to match the actual interface number. So skipping an interface should still increase the nicNum. Thanks finding and patching the issue! - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12369/#review23142 ----------------------------------------------------------- On July 9, 2013, 7:59 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12369/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 7:59 p.m.) > > > Review request for cloudstack, Chip Childers, Kelven Yang, Sateesh > Chodapuneedi, and Hugo Trippaers. > > > Bugs: CLOUDSTACK-3425 > > > Repository: cloudstack-git > > > Description > ------- > > The VR gets plumbed with 5 interfaces (passed to vmware resource as nicTOs) > but only three of them are initialized. The other two aren't used rightaway > until configured later. The extra configs being built and passed on to ESX as > part of NVP integration is copying over all the 5 nic configs but two of them > don't have uuids, so the VM reconfigure task fails because of unset values of > nvp-iface* and VR startup fails. Fixing this by ignoring those unused > interfaces when building extra configs. > > > Diffs > ----- > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 372cc1b > > Diff: https://reviews.apache.org/r/12369/diff/ > > > Testing > ------- > > With the fix, the VR comes up successfully, and guest VMs get created. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
