> On July 15, 2013, 1:07 p.m., Prasanna Santhanam wrote: > > This won't apply as it was already resolved in > > b8d876fff806e33e859016c252bd208c1ea28c2d. Is there a new diff on top of > > master? Can you please check? > > Gaurav Aradhye wrote: > Hi Prasanna, > > The commit "b8d876fff806e33e859016c252bd208c1ea28c2d" is absent in branch > master-6-17-stable branch. It's present in master. I think we have missed > this. > Also the change in try_ssh function was absent in above commit, which is > present in this diff as it is logically a generic function now. > The function try_ssh was earlier reading ip address by reading from > object and it is used in two test cases. To avoid confusion I have made it to > accept directly ip address. > > Prasanna Santhanam wrote: > Thanks - in that case we'll need only one patch here. One for master/4.2 > where you only change the try_ssh(). I'll cherry-pick over > b8d876fff806e33e859016c252bd208c1ea28c2d and the fresh patch into master-6-17 > if that's where you are testing this from.
Ok do you want me to update the diff with only change in try_ssh ? - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12546/#review23147 ----------------------------------------------------------- On July 15, 2013, 12:29 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12546/ > ----------------------------------------------------------- > > (Updated July 15, 2013, 12:29 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly > accepts ip address as parameter instead of reading it from object l > ater. This resolves object Nonetype issues which were arising due to passing > wrong parameter as ip address > > > Diffs > ----- > > test/integration/smoke/test_network.py 6788dca > > Diff: https://reviews.apache.org/r/12546/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
