----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12324/#review23243 -----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java <https://reviews.apache.org/r/12324/#comment47140> This will be inconsistent at some times when we create template from snapshot. Lets consider this case. 1) Template1: does not have xstools 2) install XS tools on the VM. 3) create vm and take snapshot of that volume. 4) now create template from snapshot created in step(3) We don't know whether tools are installed in the VM or not at the time of creation of snapshot. Steps 2 and 3 may occur many times. We cannot decide whether snapshot have XS tools are not? Please let me know if I'm missing anything. Thankyou - Harikrishna Patnala On July 15, 2013, 12:10 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12324/ > ----------------------------------------------------------- > > (Updated July 15, 2013, 12:10 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Bugs: CLOUDSTACK-3358 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3358: create template from a volume/snapshot should also take > input from User/Admin whether xstools / vmware tools installed in the VM > > > Diffs > ----- > > > api/src/org/apache/cloudstack/api/command/user/template/CreateTemplateCmd.java > 07aeb0a > server/src/com/cloud/hypervisor/HypervisorGuruBase.java 769648a > server/src/com/cloud/template/TemplateManagerImpl.java 18a69ca > > Diff: https://reviews.apache.org/r/12324/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
