----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12685/#review23515 -----------------------------------------------------------
Ship it! master: 2d4464d One review comment is if you are checking for the colon to see if the value has the schema already, then shouldn't it also check if the schema matches what's declared? But that shouldn't block this review. The code itself is technically sound. - Alex Huang On July 17, 2013, 3:46 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12685/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 3:46 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1532 > > > Repository: cloudstack-git > > > Description > ------- > > the review for the complete patch was open to long and no longer applicable, > so I am starting with smaller patches as this is really needed to implement > CLOUDSTACK-1532 > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java 5aede05 > api/test/com/cloud/network/NetworksTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/12685/diff/ > > > Testing > ------- > > unit testing > > > Thanks, > > daan Hoogland > >
