Simon, I've looked at patch and yes - it's been refactored greatly.
I wish this would have been brought up earlier :( While due to time constraint, we probably wont be able to make into 4.1.1, if we can get the patch, we will try to push it into next 4.1.2 update. Please update the ticket and ask if this patch can be back ported to 4.1. I'll do the same. Thanks ilya > -----Original Message----- > From: Simon Weller [mailto:swel...@ena.com] > Sent: Monday, July 22, 2013 11:30 AM > To: dev@cloudstack.apache.org > Subject: [ACS411] CLOUDSTACK-2188: patch request > > Hi, > > I'd like to request a patch for Cloudstack-2188 for ACS 4.1.1. > > The master commit was e56d2a401c40b4208d062c0a0ce1ec01df73dd08, but it > appears the code has been greatly re-factored since 4.1 was originally > branched. > This NPE appears to be causing a memory leak in our production > environment that consumes memory quickly due to the number of times this > NPE is being triggered. We currently have tomcat max memory set to 2G, and > individual management servers are running out of memory within 4 to 5 > days. > > MS NPE log for reference: > > 2013-07-22 09:40:47,404 DEBUG [agent.manager.AgentManagerImpl] > (AgentConnectTaskPool-1066:null) Details from executing class > com.cloud.agent.api.storage.ListVolumeCommand: success > 2013-07-22 09:40:47,407 ERROR [agent.manager.AgentManagerImpl] > (AgentConnectTaskPool-1066:null) Monitor DownloadListener says there is > an error in the connect process for 28 due to null > java.lang.NullPointerException at > com.cloud.storage.download.DownloadMonitorImpl.handleVolumeSync(Do > wnloadMonitorImpl.java:694) > at > com.cloud.storage.download.DownloadMonitorImpl.handleSync(Download > MonitorImpl.java:620) > at > com.cloud.storage.download.DownloadListener.processConnect(DownloadL > istener.java:385) > at > com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection( > AgentManagerImpl.java:611) > at > com.cloud.agent.manager.AgentManagerImpl.handleConnectedAgent(Agen > tManagerImpl.java:1111) > at > com.cloud.agent.manager.AgentManagerImpl.access$100(AgentManagerIm > pl.java:145) > at > com.cloud.agent.manager.AgentManagerImpl$HandleAgentConnectTask.ru > n(AgentManagerImpl.java:1186) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav > a:1146) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja > va:615) > at java.lang.Thread.run(Thread.java:679) > > > Thanks, > > - Si
