Hi all, Thanks you for your vote Nicolas and Daan. Thank you Wei for the tests. The reported issue will be a blocker for people installing and upgrading on Ubuntu hosts. We already have a fix and test results on the PR https://github.com/apache/cloudstack/pull/8524 look good.
I'll work with contributors and cut a new RC with this fix. Regards, Abhishek On Wed, 17 Jan 2024 at 20:59, Wei ZHOU <ustcweiz...@gmail.com> wrote: > Hi Daan, > > multipath is not used in our environments at all. > The tests for PR https://github.com/apache/cloudstack/pull/8524 look ok > until now. Let's wait for the test results. > > -Wei > > On Wed, 17 Jan 2024 at 15:16, Daan Hoogland <daan.hoogl...@gmail.com> > wrote: > > > Wei, is this with a VM/Volume not using multipath itself? If it is it > > is definitely a reason to create a new RC, if it isn't I think we can > > manage a known issue for a new feature. > > > > On Wed, Jan 17, 2024 at 2:50 PM Wei ZHOU <ustcweiz...@gmail.com> wrote: > > > > > > Thanks Ahbishek, and everyone tested or is testing RC2. > > > > > > I ran some tests on a ubuntu22 environment , and got the following > > > exception when stopping VMs. > > > > > > 2024-01-17 12:56:26,053 DEBUG [c.c.a.t.Request] > > > (AgentManager-Handler-17:null) (logid:) Seq 2-8295911988593164342: > > > Processing: { Ans: , MgmtId: 32989056598488, via: 2, Ver: v1, Flags: > 10, > > > > > > [{"com.cloud.agent.api.Answer":{"result":"false","details":"java.lang.NullPointerException > > > at com.cloud.utils.script.Script.getExitValue(Script.java:74) > > > at > > > > > > com.cloud.hypervisor.kvm.storage.MultipathSCSIAdapterBase.runScript(MultipathSCSIAdapterBase.java:476) > > > at > > > > > > com.cloud.hypervisor.kvm.storage.MultipathSCSIAdapterBase.disconnectPhysicalDiskByPath(MultipathSCSIAdapterBase.java:226) > > > at > > > > > > com.cloud.hypervisor.kvm.storage.KVMStoragePoolManager.disconnectPhysicalDiskByPath(KVMStoragePoolManager.java:205) > > > at > > > > > > com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.cleanupDisk(LibvirtComputingResource.java:3335) > > > at > > > > > > com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStopCommandWrapper.execute(LibvirtStopCommandWrapper.java:101) > > > at > > > > > > com.cloud.hypervisor.kvm.resource.wrapper.LibvirtStopCommandWrapper.execute(LibvirtStopCommandWrapper.java:49) > > > at > > > > > > com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78) > > > at > > > > > > com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1903) > > > > > > The workaround is > > > chmod +x /usr/share/cloudstack-common/scripts/storage/multipath/*.sh > > > The PR to fix it : https://github.com/apache/cloudstack/pull/8524 > > > > > > > > > Please note, this is not a -1 on the RC2. If we think this is not a > > > critical issue, we need to update the upgrade instruction for it. > > > > > > > > > -Wei > > > > > > On Mon, 15 Jan 2024 at 13:04, Abhishek Kumar <shwst...@apache.org> > > wrote: > > > > > > > Hi All, > > > > > > > > I've created a 4.19.0.0 release (RC2), with the following artifacts > up > > for > > > > a vote: > > > > > > > > Git Branch and Commit SH: > > > > https://github.com/apache/cloudstack/tree/4.19.0.0-RC20240115T1418 > > > > Commit: 38bd4fd72bdae354c4b0f615a4861fc84d67b29a > > > > > > > > Source release (checksums and signatures are available at the same > > > > location): > > > > https://dist.apache.org/repos/dist/dev/cloudstack/4.19.0.0/ > > > > > > > > PGP release keys (signed using > > 65518106473A09D7AF26B384A70BD2EAA74E2866): > > > > https://dist.apache.org/repos/dist/release/cloudstack/KEYS > > > > > > > > For testing purposes, I have uploaded the different distro packages > to: > > > > http://download.cloudstack.org/testing/4.19.0.0-RC2/ > > > > > > > > Since 4.16 the system VM template registration is no longer mandatory > > > > before upgrading, however, it can be downloaded from here if needed: > > > > https://download.cloudstack.org/systemvm/4.19/ > > > > > > > > The vote will be open for 72 hours. > > > > > > > > For sanity in tallying the vote, can PMC members please be sure to > > indicate > > > > "(binding)" with their vote? > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Regards, > > > > Abhishek > > > > > > > > > > > > -- > > Daan > > >
