vdombrovski commented on code in PR #83:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/83#discussion_r1495629658


##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -277,6 +283,11 @@ func resourceCloudStackInstanceCreate(d 
*schema.ResourceData, meta interface{})
                p.SetRootdisksize(int64(rootdisksize.(int)))
        }
 
+       if d.Get("uefi").(bool) {
+               p.SetBoottype("UEFI")
+               p.SetBootmode("Legacy")

Review Comment:
   I was thinking about adding this as a second step, if the community needs 
it. Currently I don't have any way to test the UEFI Secure mode (I'm not even 
sure it works properly in ACS). 
   
   For now this is meant to be an easy and naive implementation that covers the 
most important need, which is to run UEFI cloud images; This is also a pressing 
issue now that some distros (e.g. Ubuntu) are providing [UEFI only cloud 
images](https://cloud-images.ubuntu.com/noble/current/).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to