weizhouapache commented on PR #80:
URL: https://github.com/apache/cloudstack-go/pull/80#issuecomment-1994006010

   I checked the diff betwen this PR and latest v2.15.0
   
   1. guest OS (**_no need to fix I think_**)
   
   ```
    type GuestOSServiceIface interface {
           AddGuestOs(p *AddGuestOsParams) (*AddGuestOsResponse, error)
   -       NewAddGuestOsParams(details map[string]string, oscategoryid string, 
osdisplayname string) *AddGuestOsParams
   +       NewAddGuestOsParams(oscategoryid string, osdisplayname string) 
*AddGuestOsParams
           AddGuestOsMapping(p *AddGuestOsMappingParams) 
(*AddGuestOsMappingResponse, error)
   
   ...
   -       NewUpdateGuestOsParams(details map[string]string, id string, 
osdisplayname string) *UpdateGuestOsParams
   +       NewUpdateGuestOsParams(id string, osdisplayname string) 
*UpdateGuestOsParams
   
   ```
   
   2. CKS
   
   ```
   diff --git a/cloudstack/KubernetesService.go 
b/cloudstack/KubernetesService.go
   index 07bcd3e..4dcf1f1 100644
   --- a/cloudstack/KubernetesService.go
   +++ b/cloudstack/KubernetesService.go
   @@ -31,7 +31,7 @@ type KubernetesServiceIface interface {
           AddKubernetesSupportedVersion(p 
*AddKubernetesSupportedVersionParams) (*AddKubernetesSupportedVersionResponse, 
error)
           NewAddKubernetesSupportedVersionParams(mincpunumber int, minmemory 
int, semanticversion string) *AddKubernetesSupportedVersionParams
           CreateKubernetesCluster(p *CreateKubernetesClusterParams) 
(*CreateKubernetesClusterResponse, error)
   -       NewCreateKubernetesClusterParams(description string, 
kubernetesversionid string, name string, serviceofferingid string, size int64, 
zoneid string) *CreateKubernetesClusterParams
   +       NewCreateKubernetesClusterParams(clustertype string, name string, 
zoneid string) *CreateKubernetesClusterParams
           DeleteKubernetesCluster(p *DeleteKubernetesClusterParams) 
(*DeleteKubernetesClusterResponse, error)
           NewDeleteKubernetesClusterParams(id string) 
*DeleteKubernetesClusterParams
           DeleteKubernetesSupportedVersion(p 
*DeleteKubernetesSupportedVersionParams) 
(*DeleteKubernetesSupportedVersionResponse, error)
   
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to