fabiomatavelli commented on code in PR #71:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639582074


##########
cloudstack/provider_test.go:
##########
@@ -20,56 +20,79 @@
 package cloudstack
 
 import (
+       "context"
        "os"
        "testing"
 
-       "github.com/hashicorp/terraform/helper/schema"
-       "github.com/hashicorp/terraform/terraform"
+       "github.com/hashicorp/terraform-plugin-go/tfprotov5"
+       "github.com/hashicorp/terraform-plugin-mux/tf5muxserver"
+       "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+       "github.com/hashicorp/terraform-plugin-testing/helper/resource"
 )
 
-var testAccProviders map[string]terraform.ResourceProvider
+var testAccProviders map[string]*schema.Provider
 var testAccProvider *schema.Provider
 
 var cloudStackTemplateURL = os.Getenv("CLOUDSTACK_TEMPLATE_URL")
 
 func init() {
-       testAccProvider = Provider().(*schema.Provider)
-       testAccProviders = map[string]terraform.ResourceProvider{
+       testAccProvider = New()
+       testAccProviders = map[string]*schema.Provider{
                "cloudstack": testAccProvider,
        }
 }
 
 func TestProvider(t *testing.T) {
-       if err := Provider().(*schema.Provider).InternalValidate(); err != nil {
+       if err := New().InternalValidate(); err != nil {
                t.Fatalf("err: %s", err)
        }
 }
 
 func TestProvider_impl(t *testing.T) {
-       var _ terraform.ResourceProvider = Provider()
+       var _ *schema.Provider = New()
 }
 
-func testSetValueOnResourceData(t *testing.T) {

Review Comment:
   those functions were not in use @vishesh92



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to