Jason,
From a cursory glance, your change adds an optional new parameter to an
existing API. It seems like an enhancement to the existing feature.
Best regards,
João Jandre
On 5/27/25 16:39, Jason Hollis wrote:
João,
Thanks for the information, however I'm still not sure how things are
classified as enhancement vs new feature. I would assume this would be
an enhancement of the `update loadbalancerrule` , because it's adding a
new parameter to specify the source cidr. I just thougth I'd
make sure before I based this off the wrong branch and submitted a PR
the wrong way.
If it is in face an enhancement, and the parameter/option is not
currently in any of the code...then that is where I'm confused that this
might be a new feature??
Can you or someone look at my code and point me in the right direction
on how this fix/update can be included to the correct branches/ versions
Thanks,
Jason
On Tue May 27, 2025 at 3:16 PM EDT, João Jandre Paraquetti wrote:
Hi Jason,
If it is a bug/enchancement, I advise you to submit it to the oldest LTS
branch that is affected by the bug (or that is compatible with the
enhancement). You can check the LTS list here:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS
If it is a new feature you should submit it to the main branch, which is
from where the next minor version will be released.
Best regards,
João Jandre.
On 5/27/25 15:52, Jason Hollis wrote:
I have some code for Cloudstack that I have tested and works on 4.19.2.0
instance that I have. I would like to submit this for review and get it
merged in, but not sure which branch/tag I should/should've used to do
this
Here is the code and I had tested by basing it off of the 4.19 branch
https://github.com/apache/cloudstack/compare/4.19...American-Cloud:cloudstack:O_419_lb_update_cidr
I'm new to this for Cloudstack and would love any pointers on the best
way I can setup and test different versions of Cloudstack.. and make
sure things like this get submitted properly.
Thanks,
Jason
